Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for undefined targets (iptc.easy) - issue265 #273

Merged
merged 7 commits into from
Jun 3, 2019
Merged

Add support for undefined targets (iptc.easy) - issue265 #273

merged 7 commits into from
Jun 3, 2019

Conversation

jllorente
Copy link
Collaborator

  • Add support for undefined target with dictionary rules
  • Add support for goto targets with dictionary rules
  • Update documentation for goto targets with dictionary rules

@jllorente jllorente requested a review from ldx May 19, 2019 19:12
@coveralls
Copy link

coveralls commented May 19, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.7%) to 58.09% when pulling 57a7cc5 on issue265 into f8a6641 on master.

@jllorente jllorente mentioned this pull request May 19, 2019
Closed
@jllorente jllorente changed the title Issue265 Add support for undefined targets (iptc.easy) - issue265 May 19, 2019
@ldx
Copy link
Owner

ldx commented May 20, 2019

LGTM 👍

Let's see if Travis fixes their 2.6 environment. If not, we can remove that one.

@ldx
Copy link
Owner

ldx commented May 27, 2019

Can you please rebase this on master to fix the Travis CI build?

ldx
ldx approved these changes Jun 3, 2019
View reviewed changes
Copy link
Owner

@ldx ldx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@jllorente jllorente merged commit 6f4ac9c into master Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldx ldx ldx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jllorente @coveralls @ldx