Debian package

[ncode]

Helo,

I've done a debian package to deploy at my work ( locaweb.com.br ), and I would like to now if is it interesting to the project as well.

[ldx]

Thanks for making the package.

I built it on Ubuntu with dpkg-buildpackage, but the package is missing the actual python files:

~/Projects% dpkg --contents python-iptables_0.1.1_amd64.deb
drwxr-xr-x root/root 0 2011-12-15 22:42 ./
drwxr-xr-x root/root 0 2011-12-15 22:42 ./usr/
drwxr-xr-x root/root 0 2011-12-15 22:42 ./usr/share/
drwxr-xr-x root/root 0 2011-12-15 22:42 ./usr/share/doc/
drwxr-xr-x root/root 0 2011-12-15 22:42 ./usr/share/doc/python-iptables/
-rw-r--r-- root/root 87 2011-11-02 16:08 ./usr/share/doc/python-iptables/README
-rw-r--r-- root/root 1094 2011-12-15 22:41 ./usr/share/doc/python-iptables/copyright
-rw-r--r-- root/root 150 2011-12-15 22:41 ./usr/share/doc/python-iptables/changelog.gz
-rw-r--r-- root/root 212 2011-12-15 22:41 ./usr/share/doc/python-iptables/README.Debian

Am I missing something?

[ncode]

The package was made to work only with the new debian python packaging style. I updated just now to work on both debian and ubuntu :D.

[ldx]

Thanks! I had to add python-all-dev as a dependency to build on my laptop, though:

diff --git a/debian/control b/debian/control
index b3a3f72..d47371c 100644
--- a/debian/control
+++ b/debian/control
@@ -2,7 +2,7 @@ Source: python-iptables
Section: net
Priority: extra
Maintainer: Juliano Martinez juliano@martinez.io
-Build-Depends: cdbs (>= 0.4.49), debhelper (>= 7), python (>= 2.4), python-support
+Build-Depends: cdbs (>= 0.4.49), debhelper (>= 7), python (>= 2.4), python-support, python-all-dev (>= 2.3.5-11)
XS-Python-Version: >= 2.6
Standards-Version: 3.8.4
Homepage: https://github.com/ldx/python-iptables

It also seems there are a few generated files in the debian subdirectory:

% dh_clean
% git status                 
# On branch ncode
# Changes not staged for commit:
#   (use "git add/rm <file>..." to update what will be committed)
#   (use "git checkout -- <file>..." to discard changes in working directory)
#
#       deleted:    debian/files
#       deleted:    debian/python-iptables.debhelper.log
#       deleted:    debian/python-iptables.postinst.debhelper
#       deleted:    debian/python-iptables.prerm.debhelper
#       deleted:    debian/python-iptables.substvars
#
no changes added to commit (use "git add" and/or "git commit -a")

Can you fix these two things? Then I'll be happy to merge this.

[ncode]

I fixed both :D. it now should be clean and building without errors. Thanks

[ldx]

Thanks a lot!