Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix locating _xtables_libdir with glibc >= 2.32 #322

Closed
wants to merge 1 commit into from

Conversation

mwhudson
Copy link

It appears ldconfig -v changed its output in glibc 2.32 and now looks
like this:

/lib/x86_64-linux-gnu: (from /etc/ld.so.conf.d/x86_64-linux-gnu.conf:3)
libplds4.so -> libplds4.so
...

This breaks the regex xtables.py is using to look for the linker search
path, so I've adjusted the regex to work with the old and new formats.

It appears ldconfig -v changed its output in glibc 2.32 and now looks
like this:

/lib/x86_64-linux-gnu: (from /etc/ld.so.conf.d/x86_64-linux-gnu.conf:3)
	libplds4.so -> libplds4.so
	...

This breaks the regex xtables.py is using to look for the linker search
path, so I've adjusted the regex to work with the old and new formats.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 58.203% when pulling 18d326d on mwhudson:glibc-2.32 into 542efdb on ldx:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 58.203% when pulling 18d326d on mwhudson:glibc-2.32 into 542efdb on ldx:master.

@EvanKrall
Copy link

@ldx Can this PR or #330 be merged? It looks like #329 affects Ubuntu 22.04 (Jammy).

@ldx
Copy link
Owner

ldx commented Nov 23, 2022

@ldx Can this PR or #330 be merged? It looks like #329 affects Ubuntu 22.04 (Jammy).

Merged #330.

@ldx
Copy link
Owner

ldx commented Nov 23, 2022

Thanks for the PR! Since #330 fixes the problem, closing this one.

@ldx ldx closed this Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants