Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove any recursive option in tree retrieval from GitHub #11

Open
le-git-imate opened this issue Aug 15, 2019 · 0 comments
Open

Remove any recursive option in tree retrieval from GitHub #11

le-git-imate opened this issue Aug 15, 2019 · 0 comments
Labels
bug Something isn't working enhancement Ask to enhance an existing feature

Comments

@le-git-imate
Copy link
Owner

le-git-imate commented Aug 15, 2019 •
edited

Description of issue or feature request
Trees that need to be fetched to perform a regular commit on GitHub are not retrieved in a smart way. Actually, le-git-imate gets all trees at once using the recursive option. That is not a good option when working with large repos as it can cause a timeout.

Current behavior

  • The regular commit on GitHub does not use non-recursive approach when it comes to tree retrieval.

Expected behavior

  • Replace the recursive approach with the non-recursive one to retrieve trees on GitHub.
    P.S: The non-recursive approach is developed but not ready to be integrated yet.
@le-git-imate le-git-imate added bug Something isn't working enhancement Ask to enhance an existing feature labels Aug 15, 2019
This was referenced Aug 20, 2019
Open
Open
hmdfsn added a commit that referenced this issue Sep 20, 2019
@hmdfsn
ENH: Make GitHub tree retrieval non-recursive
d05a679 
- Remove recursive call on GitHub tree API to fetch minimum Git tree Objects
- Fix minor code format issue

Resovles: #11
@hmdfsn hmdfsn mentioned this issue Sep 20, 2019
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement Ask to enhance an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@le-git-imate