This repository has been archived by the owner on May 18, 2019. It is now read-only.
Add Linked Bricks feature #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* First rough version linked bricks * Corrected math import. * Made part detection in header case-sensitive again. * Implemented feedback first code review * Introducing levels, as solution to top-level brick check. * Cleaned code for safer merge with master. * Removed any decision based upon the .dat-header. * Limit scope of Linked Bricks to current import.
Conflicts: import_ldraw.py
|
Alrighty @geertdaelemans, I finally got your PR ready to merge and kept your name as the author. Sorry it took so long. Anyway, congratulations on your first commit into the LDR Importer! 😄 |
|
Thank you very much! I am so happy I can hardly wait to start working on my next commit... but first my other projects. ;-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Supersedes #100)