Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android cluster not disappearing #344

Closed
DavinderS opened this issue Apr 16, 2014 · 7 comments
Closed

Android cluster not disappearing #344

DavinderS opened this issue Apr 16, 2014 · 7 comments

Comments

@DavinderS
Copy link

This bug can be seen on https://www.mapbox.com/mapbox.js/example/v1.0.0/leaflet-markercluster/. I'm using a Nexus 4 on Android 4.4.2. When clicking on a cluster near the edge of the screen, the cluster will not disappear. It will open and show the markers inside, but the cluster is still there and is clickable. Clicking it will only change the zoom level, if you zoom in. Zooming out again will fix it (until clicking on it from an edge again)

Here is an image of what I'm about to click on:
png

Here is what happens after the click:
png-1

So the cluster is still there even though it's been opened.

@danzel
Copy link
Member

danzel commented Apr 16, 2014

Weird! Which one did you click on? The 293? It's in the middle of the screen though?

What browser are you using?
Does it reproduce anywhere else?

@DavinderS
Copy link
Author

Yes the 293. The second image is after the click. The 293 is still there even though it has declustered. I'm using chrome on my android and I was able to reproduce it on my desktop on a private app. I can try creating a fiddle or something to show this tomorrow.

@DavinderS
Copy link
Author

It only occurs when the cluster is at the edge of the screen. When I clicked on it here, only a third of the cluster was visible.

@danzel
Copy link
Member

danzel commented Apr 16, 2014

Fiddle would be good thanks

@DavinderS
Copy link
Author

http://jsfiddle.net/pGnLQ/54/
In order to recreate the problem on desktop, I had to play with a bit of the sizing. Here are all the changes I made : http://www.diffchecker.com/leheiinc http://www.diffchecker.com/pg0cbvin. The main code is at the bottom of the javascript section.

In order to reproduce the problem, zoom in a bit and pan so that you can only see the top of the cluster.
Something like this:
screen shot 2014-04-17 at 11 50 29 am
(You can only see the border of the cluster)
Clicking this will open the cluster without removing it
Like this:
screen shot 2014-04-17 at 11 52 09 am

@danzel
Copy link
Member

danzel commented Apr 22, 2014

Thanks for the report. Fixed in master now.

@robertkent87
Copy link

I'm having the same issue on the iPad, iOs 7.1.1 with your example http://leaflet.github.io/Leaflet.markercluster/example/marker-clustering-realworld.388.html

It only happens when the map has to pan after you click the cluster.

In this image I'm about the click the 34 cluster. Since it is near the top of the map it will have to pan to spiderfy.
photo 1

Once the map pans, zooms and expands the cluster the 34 is still there.
photo 2

ghybs added a commit to ghybs/Leaflet.markercluster that referenced this issue Mar 4, 2016
Same as Leaflet#344, which was corrected by commit 254198a in leaflet-0.7 branch only. Do the same in master branch (for Leaflet 1.0.0) as well.
Also added a dedicated test spec in zoomAnimationSpec test suite.

Took the opportunity to refactor the test suite to avoid PhantomJS memory leak.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants