Fix - flag for moonc
#432
Merged
Fix - flag for moonc
#432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`moonc` currently tells argparse to expect `-`, but actually checks for `--` on the cli, which breaks `moonc -`; this should in theory fix this
|
(this is for #431) |
|
If you put the term "Fixes #431" in your main pull request comment, GitHub will automatically link the PR with that issue and auto-close the issue if this PR is merged. |
huh i thought it only worked in commit messages, done |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moonccurrently tells argparse to expect-, but actually checks for--on the cli, which breaksmoonc -; this PR fixes this and forces-to be the only argument (like-htells us) (fixes #431)