Allow custom timestamp format #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes sense. Can you also update https://github.com/leafsphp/auth/blob/main/src/Auth.php#L269 so I merge this, thanks |
- When trying to register having USE_TIMESTAMPS to true, the insert on a mysql database fails because the default format of tick()->now() is not supported by mysql DATETIME type - With this PR it makes the format customizable so that anyone can use the desired format according to their use case
|
Updated, thanks for noticing |
mychidarko
approved these changes
May 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to register having USE_TIMESTAMPS to true, the insert on a mysql database fails because the default format of tick()->now() is not supported by mysql DATETIME type
With this PR it makes the format customizable so that anyone can use the desired format according to their use case
Please try it and let me know if this makes sense, otherwise you can close it. Thanks a lot!