Skip to content
This repository has been archived by the owner on Dec 10, 2019. It is now read-only.

Current patch not working #18

Closed
nizdi opened this issue Feb 20, 2019 · 7 comments
Closed

Current patch not working #18

nizdi opened this issue Feb 20, 2019 · 7 comments

Comments

@nizdi
Copy link

nizdi commented Feb 20, 2019

I'm not sure it's discontinued, anyway...

@Ilshidur
Copy link
Member

Hello. Thank you for your report. The project is still up, but I'm working on a full rework on my side.

I don't always watch the state of the patches, but I can confirm that the builds are not generated automatically anymore :

image

I'll try to fix this today. Stay tuned ;-)

@Ilshidur
Copy link
Member

Ilshidur commented Feb 20, 2019

OK. I got it to work. Now I have to publish the changes to the current website. I'll do it as soon as possible.

You'll be informed when I've done that.

Edit : Champion.gg seems down. I'll deploy it when they fix their website.

@nizdi
Copy link
Author

nizdi commented Feb 23, 2019

Thanks!!Waiting here. Love this, thnaks for keep workign on it.

@Ilshidur
Copy link
Member

Ilshidur commented Mar 3, 2019

Gosh, the API is still not up ... I messaged the guys, but they don't seem to respond.
That's unfortunate because the item sets generator depends on it. And I don't have the time to make my own statistics bot.

Note : the "API" is a service that provides all the datas from champion.gg to developers, so they can directly use their data instead of creating a bot that will scrap the datas from their website.

I'll keep waiting, but I don't guarantee this will be up soon ...

If you want to keep using pre-built item sets, here's Championify. This app does only crawling through their website and doesn't query the API. Thus, the app still works. They're good guys. You can use it as an alternative until I find a way to fix this 😄

Sorry again.

@Baxxster
Copy link

Baxxster commented Mar 8, 2019

Hello,

Just got a message from Champion.gg on Facebook, the API is now back up and they will release a statement about it soon!

@Ilshidur
Copy link
Member

Ilshidur commented Mar 8, 2019

I just got the same answer ! I'll have a close eye on the generator to make sure it builds the item sets correctly.

I guess champion.gg will go down, though ...

EDIT : the item sets are back up !

@nizdi
Copy link
Author

nizdi commented Mar 9, 2019

Nice!! Thanks for the work and thanks Baxxster for the info.

@nizdi nizdi closed this as completed Mar 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants