Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LeakDetector ignores hash_set #1

Open
stevenwdv opened this issue Sep 14, 2022 · 0 comments · May be fixed by #3
Open

LeakDetector ignores hash_set #1

stevenwdv opened this issue Sep 14, 2022 · 0 comments · May be fixed by #3

Comments

@stevenwdv
Copy link

stevenwdv commented Sep 14, 2022 •
edited
Loading

LeakDetector.__init__ stores the hash_set parameter to self._hash_set, but LeakDetector._compute_hashes ignores it and uses self._hasher.supported_hashes instead. This may slow down leak detection.
stevenwdv added a commit to stevenwdv/leaky-forms that referenced this issue Jan 26, 2023
@stevenwdv
Actually use hash_set in _compute_hashes
61259d4 
Closes leaky-forms#1
@stevenwdv stevenwdv linked a pull request Jan 26, 2023 that will close this issue
Open
stevenwdv added a commit to stevenwdv/leak-inspector that referenced this issue Jan 26, 2023
@stevenwdv
Actually use hash_set in _compute_hashes
f4a793f 
See also leaky-forms/leaky-forms#1
@stevenwdv stevenwdv mentioned this issue Jan 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Actually use hash_set in _compute_hashes stevenwdv/leaky-forms
1 participant
@stevenwdv