Tiny change to support Python 3.11 #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. I'll run some tests for Python 3.11. |
yangky11
approved these changes
Apr 4, 2024
|
You are welcome and happy to see it merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for this helpful library!
Python 3.11 has been around for a while, and many libraries such as PyTorch already supports it. When install LeanDojo it rejects 3.11, and I checked the link https://docs.ray.io/en/latest/ray-overview/installation.html#daily-releases-nightlies given by the comments, which says Ray (experimentally) supports 3.11. Therefore, I wonder why LeanDojo forbids 3.11 - is it because there are some known Ray bugs that will occur in LeanDojo (then this PR should definitely be rejected), or because 3.11 was not supported by Ray long ago but now things has changed?