This repository has been archived by the owner on Dec 6, 2019. It is now read-only.
2.0.3 相关问题修复。 #30
Merged
2.0.3 相关问题修复。 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var url = ''; | ||
| var protocol = 'http://'; | ||
| if (win && win.location.protocol === 'https:') { | ||
| protocol = 'https://'; | ||
| } | ||
| url = protocol + 'router-g0-push.avoscloud.com/v1/route?appId=' + appId ; | ||
| var node = ''; | ||
| switch (options.country) { |
There was a problem hiding this comment.
慎用 country 这个名字啊。。。我觉得叫 env 比较好
There was a problem hiding this comment.
region
2015-06-02 13:24 GMT+08:00 Ning Sun notifications@github.com:
In src/AV.push.js
#30 (comment):var url = ''; var protocol = 'http://'; if (win && win.location.protocol === 'https:') { protocol = 'https://'; }
url = protocol + 'router-g0-push.avoscloud.com/v1/route?appId=' + appId ;var node = '';switch (options.country) {慎用 country 这个名字啊。。。我觉得叫 env 比较好
—
Reply to this email directly or view it on GitHub
https://github.com/leancloud/js-push-sdk/pull/30/files#r31493577.
| break; | ||
| case 'us': | ||
| options.host = 'avoscloud.us'; | ||
| break; |
|
除了一个 comment 都 LGTM 了，可以合并了 |
|
已增加，合并了。 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sunng87