Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] 创建 conversation 成功之后回调中返回当前的 convObject。 #61

Merged
merged 5 commits into from
Apr 9, 2015

Conversation

wangxiao
Copy link
Contributor

@wangxiao wangxiao commented Apr 7, 2015

No description provided.

@wangxiao
Copy link
Contributor Author

wangxiao commented Apr 8, 2015

@sunng87 @sunchanglong
麻烦宁姐和大龙看下。


// 是否对消息中的 HTML 进行转义
if (cache.options.encodeHTML) {
data.msg = tool.encodeHTML(data.msg);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的 data.msg 会不会是个 json?之前处理了预定义格式的json

@wangxiao
Copy link
Contributor Author

wangxiao commented Apr 8, 2015

已修正,确实有问题,修改的时候没考虑到,谢谢宁姐。

// 对象类型
if (typeof(source) === 'object') {
for (var key in source) {
source[key] = tool.encodeHTML(source[key]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里会不会把数字变成字符串了。。。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还真是。。。我想想。。。

sunng87 added a commit that referenced this pull request Apr 9, 2015
[feature] 创建 conversation 成功之后回调中返回当前的 convObject。
@sunng87 sunng87 merged commit 4418c25 into leancloud:master Apr 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants