Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact on maintain the progress of processing records #17

Merged
merged 1 commit into from
Mar 9, 2020

Conversation

ylgrgyq
Copy link
Contributor

@ylgrgyq ylgrgyq commented Mar 9, 2020

use a dedicated class to maintain the progress of processing records

@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #17 into master will increase coverage by 0.46%.
The diff coverage is 93.7%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #17      +/-   ##
============================================
+ Coverage     89.06%   89.53%   +0.46%     
- Complexity      262      271       +9     
============================================
  Files            24       25       +1     
  Lines           832      831       -1     
  Branches         86       82       -4     
============================================
+ Hits            741      744       +3     
+ Misses           44       41       -3     
+ Partials         47       46       -1
Impacted Files Coverage Δ Complexity Δ
...ancloud/kafka/consumer/LcKafkaConsumerBuilder.java 90.64% <ø> (ø) 54 <0> (ø) ⬇️
...cn/leancloud/kafka/consumer/RebalanceListener.java 95.91% <100%> (+0.26%) 16 <3> (+1) ⬆️
...main/java/cn/leancloud/kafka/consumer/Fetcher.java 87.33% <100%> (+0.17%) 31 <4> (+1) ⬆️
...leancloud/kafka/consumer/AbstractCommitPolicy.java 100% <100%> (+3.8%) 8 <2> (-25) ⬇️
.../cn/leancloud/kafka/consumer/AutoCommitPolicy.java 100% <100%> (ø) 4 <3> (ø) ⬇️
...ka/consumer/AbstractRecommitAwareCommitPolicy.java 91.3% <100%> (ø) 12 <0> (ø) ⬇️
.../cn/leancloud/kafka/consumer/SyncCommitPolicy.java 100% <100%> (ø) 4 <3> (ø) ⬇️
...ncloud/kafka/consumer/PartialSyncCommitPolicy.java 100% <100%> (ø) 4 <3> (ø) ⬇️
...a/cn/leancloud/kafka/consumer/LcKafkaConsumer.java 87.34% <100%> (ø) 23 <0> (ø) ⬇️
.../cn/leancloud/kafka/consumer/NoOpCommitPolicy.java 60% <60%> (+22.5%) 3 <3> (ø) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9541107...53d06ee. Read the comment docs.

@ylgrgyq ylgrgyq marked this pull request as ready for review March 9, 2020 22:11
@ylgrgyq ylgrgyq merged commit 221eaeb into master Mar 9, 2020
@ylgrgyq ylgrgyq deleted the refact/progress branch March 9, 2020 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant