重构 Class Hook 中用户信息的获取 #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jysperm
commented
May 30, 2016
jysperm
commented
- 不再从 req.body.user 获取用户信息
- 对于 before 和 after 类的 Hook 检查签名
|
https://github.com/leancloud/uluru-platform/issues/2242 已添加 onVerified/onLogin 以及实时通讯的 Hook 签名验证（因为是新加的验证，会将校验失败的请求打印出来） |
This was referenced Jun 13, 2016
| '_conversationAdd', '_conversationRemove', '_conversationUpdate' | ||
| ], splited[1])) { | ||
| if (!utils.verifyHookSign(AV.masterKey, splited[1], req.body.__sign)) { | ||
| console.trace('LeanEngine: verifyHookSign failed'); |
There was a problem hiding this comment.
这里建议把 url 也输出，否则只有一个错误提示意义不大。
是否也输出下 remote ip？因为我们服务器发出的请求一半不会有问题，如果是仿冒的请求，有个 ip 也许会有一点帮助。
|
已在线上测试通过所有 Hook 的验证 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.