Basic REST client implementation with unit tests #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private static function getRequestHeaders($headers, $useMasterKey) { | ||
| $h = self::$default_headers; | ||
|
|
||
| $h['X-AVOSCloud-Application-Production'] = self::$useProduction ? 1 : 0; |
There was a problem hiding this comment.
现在 LeanEngine / 后端存储都支持短 header 了，推荐只使用短 header，不考虑之前的兼容性了。(如果要实现 php LeanEngine SDK 的话需要兼容)
下面 header 相关的地方也需要修改。
相关 issue： https://github.com/leancloud/uluru-platform/issues/1335
There was a problem hiding this comment.
已与 LeanEngine 确定，SDK 中只需要支持短 header。在下一个 PR 调整。
juvenn
added a commit
that referenced
this pull request
Sep 16, 2015
Basic REST client implementation with unit tests
| self::$appMasterKey = $appMasterKey; | ||
|
|
||
| self::$default_headers = array( | ||
| 'X-AVOSCloud-Application-Id' => self::$appId, |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
基于 php-curl 的最基本的REST client，实现基本的 request, get, post, put, delete 接口。