Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement basic Object model with Set and Increment operation #2

Merged
merged 10 commits into from
Sep 23, 2015
Merged

Implement basic Object model with Set and Increment operation #2

merged 10 commits into from
Sep 23, 2015

Conversation

juvenn
Copy link
Member

@juvenn juvenn commented Sep 21, 2015

  • 支持形如 X-LC-Id 的短 header,参见 leancloud/uluru-platform#1335
  • 实现 LeanObject 的 SetOperation, IncrementOperation
  • 实现 LeanObject 的 save, fetch,但还不支持嵌套对象的存储

class LeanObjectTest extends PHPUnit_Framework_TestCase {
public function setUp() {
LeanClient::initialize(
getenv("LEANCLOUD_APP_ID"),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

测试里面要不要统一写成 LC_APP_ID 的形式?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好建议,和其它 SDK 保持一致是最好的。我会立即调整。

@juvenn
Copy link
Member Author

juvenn commented Sep 22, 2015

新的 commits 做了两个改动:

  • 环境变量由 LEANCLOUD_APP_ID 更换成 LC_APP_ID
  • 在 REST 方法的注释里移除了多余的 $method 参数

juvenn added a commit that referenced this pull request Sep 23, 2015
Implement basic Object model with Set and Increment operation
@juvenn juvenn merged commit 92cd3a6 into leancloud:master Sep 23, 2015
@fdddf fdddf mentioned this pull request May 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants