-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement LeanUser for user management #6
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
juvenn
commented
Oct 15, 2015
- REST Client now requires explicitly passing session token
- Implemented session based storage for persisting session data
- Implemented cookie based storage for persisting session data
- Implemented LeanUser user management:
- account verify and password reset by email
- account verify and password reset by mobile phone
- link and unlink with 3rd-party auth data
- Attach session storage to LeanClient for persisting current user session token
* @param array $headers Optional headers | ||
* @param bool $useMasterkey Use master key or not, optional | ||
* @return array json decoded associative array | ||
* @throws ErrorException, LeanException | ||
*/ | ||
public static function request($method, $path, $data, | ||
$sessionToken=null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
REST 方法新增参数,要求显示传入 sessionToken
In many user test cases we tried to signup users with same username, which failed on Travis, as Travis run tests for many PHP versions in parallel. It results username collisions, and failed tests. Using one shared user for many test cases, we try to reduce username collisions.
juvenn
added a commit
that referenced
this pull request
Oct 19, 2015
Implement LeanUser for user management
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.