Fix new dart compatibility issue (#57)

* Fix new dart compatibility issue * Bump leancode_lint to 3.0.0
leancodepl · Jun 1, 2023 · b171159 · b171159
1 parent 9db120b
commit b171159
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 10 deletions.
diff --git a/packages/comms/CHANGELOG.md b/packages/comms/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.0.11
+
+- Fix new dart compatibility issue
+
 ## 0.0.10
 
 - Fix one off messages getting buffered when there are active `Listener`s (#54)

diff --git a/packages/comms/lib/src/message_sink_register.dart b/packages/comms/lib/src/message_sink_register.dart
@@ -36,7 +36,7 @@ class MessageSinkRegister {
   final _uuid = const Uuid();
 
   /// All message sinks and their id's added with [_add].
-  final _messageSinks = <String, StreamSink>{};
+  final _messageSinks = <String, StreamSink<dynamic>>{};
 
   /// All last messages sent with each type
   final _messageBuffers = <Type, _BufferedMessage<dynamic>>{};

diff --git a/packages/comms/lib/src/multi_listener.dart b/packages/comms/lib/src/multi_listener.dart
@@ -5,12 +5,12 @@ part of '../comms.dart';
 class ListenerDelegate<T> with Listener<T> {
   ListenerDelegate();
 
-  late final OnMessage _onMessage;
-  late final OnMessage _onInitialMessage;
+  late final OnMessage<T> _onMessage;
+  late final OnMessage<T> _onInitialMessage;
 
   @protected
   @nonVirtual
-  void _init(OnMessage onMessage, OnMessage onInitialMessage) {
+  void _init(OnMessage<T> onMessage, OnMessage<T> onInitialMessage) {
     _onMessage = onMessage;
     _onInitialMessage = onInitialMessage;
     listen();
@@ -38,7 +38,7 @@ class ListenerDelegate<T> with Listener<T> {
 ///
 ///  * [Listener], which enables listening to messages of single type.
 mixin MultiListener {
-  List<ListenerDelegate> get listenerDelegates;
+  List<ListenerDelegate<dynamic>> get listenerDelegates;
 
   /// Starts message receiving.
   ///
@@ -48,7 +48,7 @@ mixin MultiListener {
   @nonVirtual
   void listen() => listenerDelegates.forEach(_listen);
 
-  void _listen(ListenerDelegate listenerDelegate) => listenerDelegate
+  void _listen(ListenerDelegate<dynamic> listenerDelegate) => listenerDelegate
     .._init(
       onMessage,
       onInitialMessage,
@@ -71,5 +71,6 @@ mixin MultiListener {
   @nonVirtual
   void cancel() => listenerDelegates.forEach(_cancel);
 
-  void _cancel(ListenerDelegate listenerDelegate) => listenerDelegate.cancel();
+  void _cancel(ListenerDelegate<dynamic> listenerDelegate) =>
+      listenerDelegate.cancel();
 }
diff --git a/packages/comms/pubspec.yaml b/packages/comms/pubspec.yaml
@@ -1,16 +1,16 @@
 name: comms
 description: Simple communication pattern abstraction on streams, created for communication between logic classes.
-version: 0.0.10
+version: 0.0.11
 homepage: https://github.com/leancodepl/comms
 
 environment:
-  sdk: ">=2.17.0 <=3.0.0"
+  sdk: ">=2.17.0 <3.0.0"
 
 dependencies:
   logging: ^1.0.2
   meta: ^1.7.0
   uuid: ^3.0.6
 
 dev_dependencies:
-  leancode_lint: ^2.1.0+1
+  leancode_lint: ^3.0.0
   test: ^1.16.4