-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
login_client improvements #12
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Albert221
added
enhancement
New feature or request
p: login_client
Related to the login_client package
p: login_client_flutter
Related to the login_client_flutter package
labels
Jan 7, 2021
Albert221
changed the title
login_client after-use improvements
login_client improvements
Jan 7, 2021
Codecov Report
@@ Coverage Diff @@
## master #12 +/- ##
===========================================
- Coverage 72.85% 45.66% -27.19%
===========================================
Files 3 11 +8
Lines 70 127 +57
===========================================
+ Hits 51 58 +7
- Misses 19 69 +50
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mateuszwojtczak
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
p: login_client_flutter
Related to the login_client_flutter package
p: login_client
Related to the login_client package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After using this library in a production app, there were few issues discovered. This Pull Request fixes them.
Also, I went back to the
onCredentialsChanged
stream in theLoginClient
class as it was in the 0.* versions of the login_client library. It's just much easier for the developer and cleaner to use stream instead of passing a callback that the developer would have to prospectively somehow reach from other parts of the code.login_client
clientId
andclientSecret
now default to an empty string.oauth2
Credentials
,AuthorizationException
andExpirationException
.onCredentialsChanged
stream toLoginClient
.credentialsChangedCallback
.login_client_flutter
Closes #11.