Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves an issue where test bundler would generate invalid code if the file path included dashes #2120

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kodypeterson
Copy link

Identified an issue where having dashes (-) in your file path would result in invalid dart code being generated.

@github-actions github-actions bot added the package: patrol_cli Related to the patrol_cli package label Feb 20, 2024
@piotruela
Copy link
Collaborator

Thanks for the PR. We recently opened a topic of the separators and wanted to change them into something which would work universally and I like this idea. But before we will go with it we need to make sure that it will not break running tests on device farms (some of them parses the output of the console and expect it to be in specific form).

@mateuszwojtczak
Copy link
Contributor

Hi @kodypeterson!
Could you create the issue with a reproducible sample with this one?
We would like to investigate it, but I'm not sure if the PR is the right place for it, especially that we might want to choose another approach to that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: patrol_cli Related to the patrol_cli package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants