Custom selector improvements #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartekpacia
force-pushed
the
feature/custom_selectors_improvements
branch
from
eb79e95
to
0f2593b
Compare
shilangyu
reviewed
Jul 4, 2022
bartekpacia
added a commit
that referenced
this pull request
Sep 15, 2022
* make it possible to pass another `MaestroFinder` to `MaestroFinder.withDescendant` * update readme * MaestroTester: forward WidgetTester.pump() and WidgetTester.pumpAndSettle() * add tests * hit bug with parent finders not working * add .idea to .gitignore * fix bug with parent finders not working * add running tests of `package:maestro_test` to `maestro_test-prepare` workflow * add first simple tests for MaestroFinder.withDescendant() * add a truckload of docs * add more docs * revamp directory structure to better show what is native and what not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimenting with making custom selectors more flexible.
TODO: Create an example app complex enough to show all possibilities of custom selectors. It will also serve as tests for custom selectors themselves.
related to #1, follow up of #75