Fix dashes in ARBs filenames with locales having more than language #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Albert221
force-pushed
the
bug/80-locale-dash-filename
branch
from
b519a64
to
977464a
Compare
|
I'm not yet sure whether I should capitalize the filenames or keep them all lowercase |
bartekpacia
approved these changes
Dec 8, 2023
Comment on lines
+80
to
+85
| for dir in l10n l10n_prefixed; do | ||
| for locale in en pl en_HK sr sr_Cyrl es es_419; do | ||
| echo "=== lib/$dir/app_$locale.arb ===" | ||
| cat lib/$dir/app_$locale.arb | ||
| done | ||
| done |
There was a problem hiding this comment.
I'm against having more than a few lines of shell code in GH Actions, but looks like this is purely for convenience and not criticial to integration test itself. So OK.
| "slices" | ||
| "strings" | ||
|
|
||
| "github.com/pkg/errors" |
There was a problem hiding this comment.
this package is archived fyi
there's errors in stdlib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@@localecorrectlyFixes #80.