upgrade/dotnet8 (#94)

* done * removed validation that checks buffer is unwritted case sucess if false dotnet/runtime#95012 * minor adjusts
leandromoh · Nov 20, 2023 · c2d7561 · c2d7561
1 parent 6f305da
commit c2d7561
Show file tree

Hide file tree

Showing 9 changed files with 23 additions and 29 deletions.
diff --git a/README.md b/README.md
@@ -14,10 +14,10 @@ Even the focus of this library being data mapping to objects (classes, structs,
 
 ## RecordParser is a Zero Allocation Writer/Reader Parser for .NET Core
 
-1. It supports .NET 6, 7 and .NET Standard 2.1
+1. It supports .NET 6, 7, 8 and .NET Standard 2.1
 2. It has minimal heap allocations because it does intense use of [Span](https://docs.microsoft.com/en-us/archive/msdn-magazine/2018/january/csharp-all-about-span-exploring-a-new-net-mainstay) type, a .NET type designed to have high-performance and reduce memory allocations [(see benchmark)](/Benchmark.md)
 3. It is even more performant because the relevant code is generated using [expression trees](https://docs.microsoft.com/dotnet/csharp/expression-trees), which once compiled is fast as handwriting code
-4. It supports parse for ANY type: classes, structs, records, arrays, tuples etc. 
+4. It supports parse for ANY type: classes, structs, records, arrays, tuples etc 
 5. It supports to map values for properties, fields, indexers, etc.
 6. It does not do [boxing](https://docs.microsoft.com/dotnet/csharp/programming-guide/types/boxing-and-unboxing) for structs.
 7. It is flexible: you can choose the most convenient way to configure each of your parsers: indexed or sequential configuration
@@ -58,6 +58,8 @@ Third Party Benchmarks
 
 *ㅤyou can use a "string pool" to avoid creating multiple instances of strings with same content.
 
+NOTE: MOST EXAMPLES USE TUPLES FOR SIMPLICITY. PARSER ACTUALLY WORKS FOR ANY TYPE (CLASSES, STRUCTS, RECORDS, ARRAYS, TUPLES, ETC)
+
 ## Fixed Length Reader
 There are 2 flavors for mapping: indexed or sequential.  
 

diff --git a/RecordParser.Benchmark/RecordParser.Benchmark.csproj b/RecordParser.Benchmark/RecordParser.Benchmark.csproj
@@ -2,8 +2,8 @@
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
-    <TargetFrameworks>net7.0</TargetFrameworks>
-    <LangVersion>10</LangVersion>
+    <TargetFrameworks>net8.0</TargetFrameworks>
+    <LangVersion>latest</LangVersion>
 	<!--<DefineConstants>TEST_ALL</DefineConstants>-->
   </PropertyGroup>
 

diff --git a/RecordParser.Test/FixedLengthWriterBuilderTest.cs b/RecordParser.Test/FixedLengthWriterBuilderTest.cs
@@ -62,7 +62,7 @@ public void Given_value_using_standard_format_should_parse_without_extra_configu
         [InlineData(48)]
         [InlineData(01)]
         [InlineData(00)]
-        public void Given_destination_shorter_than_max_position_especified_should_write_nothing(int destinationSize)
+        public void Given_destination_shorter_than_max_position_especified_then_chars_written_should_be_zero(int destinationSize)
         {
             // Arrange
 
@@ -88,7 +88,6 @@ public void Given_destination_shorter_than_max_position_especified_should_write_
 
             success.Should().BeFalse();
             charsWritten.Should().Be(0);
-            destination.ToString().Should().Be(new string(default, destinationSize));
         }
 
         [Fact]
@@ -115,11 +114,8 @@ public void Given_string_value_larger_than_designated_space_should_write_until_r
             success.Should().BeFalse();
 
             var result = destination.Slice(0, charsWritten);
-            var unwritted = destination.Slice(charsWritten);
-            var freeSpace = destination.Length - charsWritten;
 
             result.Should().Be("2020.05.23");
-            unwritted.Should().Be(new string(default, freeSpace));
         }
 
         [Fact]
@@ -146,11 +142,8 @@ public void Given_non_string_value_larger_than_designated_space_should_write_unt
             success.Should().BeFalse();
 
             var result = destination.Slice(0, charsWritten);
-            var unwritted = destination.Slice(charsWritten);
-            var freeSpace = destination.Length - charsWritten;
 
             result.Should().Be("foo bar baz----");
-            unwritted.Should().Be(new string(default, freeSpace));
         }
 
         [Fact]

diff --git a/RecordParser.Test/FixedLengthWriterSequentialBuilderTest.cs b/RecordParser.Test/FixedLengthWriterSequentialBuilderTest.cs
@@ -63,7 +63,7 @@ public void Given_value_using_standard_format_should_parse_without_extra_configu
         [InlineData(48)]
         [InlineData(01)]
         [InlineData(00)]
-        public void Given_destination_shorter_than_max_position_especified_should_write_nothing(int destinationSize)
+        public void Given_destination_shorter_than_max_position_especified_then_chars_written_should_be_zero(int destinationSize)
         {
             // Arrange
 
@@ -92,7 +92,6 @@ public void Given_destination_shorter_than_max_position_especified_should_write_
 
             success.Should().BeFalse();
             charsWritten.Should().Be(0);
-            destination.ToString().Should().Be(new string(default, destinationSize));
         }
 
         [Fact]
@@ -120,11 +119,8 @@ public void Given_string_value_larger_than_designated_space_should_write_until_r
             success.Should().BeFalse();
 
             var result = destination.Slice(0, charsWritten);
-            var unwritted = destination.Slice(charsWritten);
-            var freeSpace = destination.Length - charsWritten;
 
             result.Should().Be("2020.05.23");
-            unwritted.Should().Be(new string(default, freeSpace));
         }
 
         [Fact]
@@ -152,11 +148,8 @@ public void Given_non_string_value_larger_than_designated_space_should_write_unt
             success.Should().BeFalse();
 
             var result = destination.Slice(0, charsWritten);
-            var unwritted = destination.Slice(charsWritten);
-            var freeSpace = destination.Length - charsWritten;
 
             result.Should().Be("foo bar baz----");
-            unwritted.Should().Be(new string(default, freeSpace));
         }
 
         [Fact]

diff --git a/RecordParser.Test/RecordParser.Test.csproj b/RecordParser.Test/RecordParser.Test.csproj
@@ -1,8 +1,8 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>net7.0</TargetFrameworks>
-    <LangVersion>11</LangVersion>
+    <TargetFrameworks>net8.0</TargetFrameworks>
+    <LangVersion>latest</LangVersion>
     <IsPackable>false</IsPackable>
   </PropertyGroup>
 

diff --git a/RecordParser.Test/VariableLengthWriterBuilderQuotedFieldTest.cs b/RecordParser.Test/VariableLengthWriterBuilderQuotedFieldTest.cs
@@ -146,7 +146,9 @@ public void Given_text_shorter_than_destination_should_not_write(string value, i
             var freeSpace = destination.Length - charsWritten;
 
             result.Should().Be(expected);
-            unwritted.Should().Be(new string(default, freeSpace));
+
+            if (success)
+                unwritted.Should().Be(new string(default, freeSpace));
         }
 
         public enum MapTextType

diff --git a/RecordParser.Test/VariableLengthWriterBuilderTest.cs b/RecordParser.Test/VariableLengthWriterBuilderTest.cs
@@ -205,7 +205,9 @@ public void Given_too_short_destination_should_write_while_have_enough_space(int
             var freeSpace = destination.Length - charsWritten;
 
             result.Should().Be(expected);
-            unwritted.Should().Be(new string(default, freeSpace));
+
+            if (success)
+                unwritted.Should().Be(new string(default, freeSpace));
         }
 
         [Fact]

diff --git a/RecordParser.Test/VariableLengthWriterSequentialBuilderTest.cs b/RecordParser.Test/VariableLengthWriterSequentialBuilderTest.cs
@@ -211,7 +211,9 @@ public void Given_too_short_destination_should_write_while_have_enough_space(int
             var freeSpace = destination.Length - charsWritten;
 
             result.Should().Be(expected);
-            unwritted.Should().Be(new string(default, freeSpace));
+
+            if (success)
+                unwritted.Should().Be(new string(default, freeSpace));
         }
 
         [Fact]

diff --git a/RecordParser/RecordParser.csproj b/RecordParser/RecordParser.csproj
@@ -2,8 +2,8 @@
 
   <PropertyGroup>
     <PackageId>RecordParser</PackageId>
-    <TargetFrameworks>netstandard2.1;net6.0;net7.0</TargetFrameworks>
-    <LangVersion>10</LangVersion>
+    <TargetFrameworks>netstandard2.1;net6.0;net7.0;net8.0</TargetFrameworks>
+    <LangVersion>latest</LangVersion>
     <Authors>Leandro Fernandes Vieira (leandromoh)</Authors>
     <Description>
 	RecordParser is a expression tree based parser that helps you to write maintainable parsers with high-performance and zero allocations, thanks to Span type.  
@@ -14,7 +14,7 @@
     <PackageProjectUrl>https://github.com/leandromoh/RecordParser</PackageProjectUrl>
     <RepositoryUrl>https://github.com/leandromoh/RecordParser</RepositoryUrl>
     <PackageTags>tsv parser performance csv mapper file flat reader dotnet-core span flatfile expression-tree delimited fixedlength</PackageTags>
-    <Version>2.2.1</Version>
+    <Version>2.3.0</Version>
     <PackageReleaseNotes>
      https://github.com/leandromoh/RecordParser/blob/master/release_notes.md
     </PackageReleaseNotes>
@@ -38,7 +38,7 @@
 
   <PropertyGroup Condition="
 		( '$(Configuration)' == 'Debug' OR '$(Configuration)' == 'Release') AND
-		( '$(TargetFramework)' == 'net5.0' OR '$(TargetFramework)' == 'net6.0' OR '$(TargetFramework)' == 'net7.0') AND
+		( '$(TargetFramework)' == 'net6.0' OR '$(TargetFramework)' == 'net7.0' OR '$(TargetFramework)' == 'net8.0') AND
 		( '$(Platform)' == 'AnyCPU') ">
 		<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
   </PropertyGroup>