Add testing harness #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much @ryansch do you need a version of it? |
| value: SecureRandom.uuid | ||
| } | ||
| elsif @testing_mode == :fail | ||
| return false |
There was a problem hiding this comment.
@ryansch With this line you modified the behaviour of lock() to not yield in case try_lock_instances failed (in testing mode, of course). In fact, your application code should probably have error handling for when the block parameter is false, so I presume you would want to test that, too.
Change it to lock_info = false?
There was a problem hiding this comment.
You're absolutely correct.
|
thanks @maltoe |
|
Thanks @ryansch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use this testing harness in our application tests.