Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebased extend #24

Merged
merged 5 commits into from Oct 7, 2015
Merged

Rebased extend #24

merged 5 commits into from Oct 7, 2015

Conversation

maltoe
Copy link
Collaborator

@maltoe maltoe commented Oct 7, 2015

Rebased #20 on top of master again and fixed lock! to also handle extend parameter. Should be good now.

@seamusabshere please take a look again

@maltoe maltoe mentioned this pull request Oct 7, 2015
Closed
@maltoe maltoe changed the title Extend Rebased extend Oct 7, 2015
@maltoe
Copy link
Collaborator Author

maltoe commented Oct 7, 2015

And btw thanks @seamusabshere for using keyword parameters so I could find out about the double-splat ** operator again 😄

leandromoreira added a commit that referenced this pull request Oct 7, 2015
@leandromoreira
Merge pull request #24 from leandromoreira/extend-rebased
f3518fc 
Rebased extend
@leandromoreira leandromoreira merged commit f3518fc into master Oct 7, 2015
@leandromoreira
Copy link
Owner

Version updated!
🍻 thanks, as always @maltoe and @seamusabshere and @ivoanjo

@ivoanjo
Copy link

ivoanjo commented Oct 12, 2015

Awesome work! 👍

@maltoe maltoe deleted the extend-rebased branch November 16, 2015 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maltoe @leandromoreira @ivoanjo @seamusabshere