Set default Redis timeout to 100ms. #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As indicated in the algorithm description [0], an implementation should set the Redis communication timeout to something small compared to the maximum validity time (TTL). As @antirez stated [1] it should be about two order of magnitude smaller. Given expected TTL times in the 1 - 10 seconds range (depending on the amount of code to be executed in a caller's critical section), this should be in the 10 - 100 ms range. Set to 100ms per default. [0] http://redis.io/topics/distlock [1] antirez/redlock-rb#3
|
@maltoe I think it's useful to let people set |
|
@leandromoreira I agree. We could provide a default TTL, but in the end it is the users duty to estimate the lock time needed for his critical code to complete, so I guess it's actually quite good to require this information in |
|
@maltoe totally agree with default 100ms |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit, not sure if we want to mangle in the TTL per
lock()call or not.