Refactor extend life feature. #42
Conversation
* Remove Client#extend_life and #extend_life! methods, offer an additional extend_life option for Client#lock instead. * Pass options hash down the line to try_lock_instances, only there decide which script to use, etc. * Fix specs and testing helper. Fixes #36.
maltoe
force-pushed
the
fix_36_refactor_extend_life
branch
from
e536f71
to
7665862
Compare
|
@leandromoreira Coveralls is funny, coverage decreased as I removed a bunch of (covered) lines... The codeship CI tool I cannot access for some reason, seems it is private. Can you tell me what it says? |
One should not believe in coveralls small percentage
I'll check, I think we can remove it since we already have travis, what do you think? |
|
Sure, as said I can't even view it, so let's remove it :) |
|
Btw, @jonp gave his thumbs-up, so if you're fine with the changes, we could merge this before people start using |
| if @testing_mode == :bypass | ||
| { | ||
| validity: ttl, | ||
| resource: resource, | ||
| value: extend ? extend.fetch(:value) : SecureRandom.uuid | ||
| value: options[:extend] ? options[:extend].fetch(:value) : SecureRandom.uuid |
There was a problem hiding this comment.
options.fetch(:extend, SecureRandom.uuid)
There was a problem hiding this comment.
yeah, but we need options[:extend][:value]
Came late to the party :)
Nice addition @jonp. Would you be ok with the changes I did here? Instead of having a dedicated
extend_lifemethod, you can use theextend_lifeparameter. Also keeps the semantics oflockwithextendthe same as before, and does not replicate behaviour oftry_lock_instancesinextend_lifemethod.