Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect from TTL units regressions (see #44) #45

Closed
wants to merge 2 commits into from

Conversation

thbar
Copy link
Contributor

@thbar thbar commented Jul 23, 2016

In this PR:

I will work later on another PR (or add to this one if it's not yet merged) to tweak the README accordingly.

@coveralls
Copy link

coveralls commented Jul 23, 2016

Coverage Status

Coverage remained the same at 98.496% when pulling 0ed9683 on thbar:ttl-specs into 7d9c91a on leandromoreira:master.

@leandromoreira
Copy link
Owner

LGTM

@maltoe
Copy link
Collaborator

maltoe commented Jul 25, 2016

me too, although I'm generally not a big fan of things like 50.times ... do in the specs. Isn't the "extend resets the TTL" functionality also already covered implicitly by the second spec? :)

@leandromoreira
Copy link
Owner

ping?

@thbar
Copy link
Contributor Author

thbar commented Dec 22, 2016

I haven't looked back at the code since July (this was a codebase for a client I'm not working for at the moment), so my memory is a bit fuzzy with regard to the question asked by @maltoe. I'm not a huge fan of 50.times either!

@maltoe
Copy link
Collaborator

maltoe commented Feb 27, 2018

closing in favor of #61

@maltoe maltoe closed this Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants