#99: Fixing bug with infinite loop and showArrows=false

leandrowd · Apr 19, 2017 · eef9597 · eef9597
1 parent 1ccf3ad
commit eef9597
Show file tree

Hide file tree

Showing 3 changed files with 7,400 additions and 2 deletions.
diff --git a/src/components/Carousel.js b/src/components/Carousel.js
@@ -414,9 +414,9 @@ module.exports = React.createClass({
         var canShowArrows = this.props.showArrows && itemsLength > 1;
 
         // show left arrow?
-        var hasPrev = canShowArrows && this.state.selectedItem > 0 || this.props.infiniteLoop;
+        var hasPrev = canShowArrows && (this.state.selectedItem > 0 || this.props.infiniteLoop);
         // show right arrow
-        var hasNext = canShowArrows && this.state.selectedItem < itemsLength - 1 || this.props.infiniteLoop;
+        var hasNext = canShowArrows && (this.state.selectedItem < itemsLength - 1 || this.props.infiniteLoop);
         // obj to hold the transformations and styles
         var itemListStyles = {};
 

diff --git a/stories/index.js b/stories/index.js
@@ -47,6 +47,16 @@ storiesOf('Carousel', module)
         { baseChildren.props.children }
     </Carousel>
   ))
+  .add('no arrows + infinite loop + auto play', () => (
+    <Carousel showArrows={false} infiniteLoop autoPlay>
+        { baseChildren.props.children }
+    </Carousel>
+  ))
+  .add('no arrows + infinite loop + emulateTouch', () => (
+    <Carousel showArrows={false} infiniteLoop emulateTouch>
+        { baseChildren.props.children }
+    </Carousel>
+  ))
   .add('no status', () => (
     <Carousel showStatus={false}>
         { baseChildren.props.children }