Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linux] fix: cannot drag again after startDragging #203

Merged
merged 1 commit into from Aug 20, 2022

Conversation

Kingtous
Copy link
Contributor

@Kingtous Kingtous commented Aug 19, 2022

Hi from RustDesk!

This PR includes fixes for dragging window issue on Linux.

Problems: Cannot drag again immediately after a successful drag. (can drag -> cannot drag -> can drag -> cannot drag ...)

  • use GestureDetector.onPanDown to trigger windowManager.startDragging, window successfully being moved. Then we release mouse, and want to drag again. It does not works, the window does not moved. We need to drag again, and it works.

Solutions: (inspired by bitsdojo_window)

  • gtk_drag influences button release event, which affects flutter click logic. So the workaround is to send a button release event to event box.

@Kingtous Kingtous changed the title fix: cannot drag again after startDragging [Linux] fix: cannot drag again after startDragging Aug 19, 2022
@Kingtous
Copy link
Contributor Author

reproduce test case: https://github.com/Kingtous/window_manager_move_test

@lijy91
Copy link
Member

lijy91 commented Aug 20, 2022

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants