Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: add the current node to engines.node in package.json #7

Closed
CroniD opened this issue Jul 27, 2017 · 1 comment
Closed

Comments

@CroniD
Copy link

CroniD commented Jul 27, 2017

Hi there,

it would be nice if the cli may add the current node version (the one that was used to init the project) to engines.node in package.json as restriction.

E.g.

{
	"engines": {
		"node": ">=6.11.1"
	}
}

Please keep in mind that the version that is used in the init process might be lower than the defined version one has to use for the cli. E.g. it is possible using 6.8 to use the cli. In this case you might consider using the defined minimum version of the cli instead.

BTW: Or you may add this restriction to the cli's package.json, so you don't have to look at this case at all.

BTW2: It may be wise to define engines.npm as well, but I'm not sure about that.

Best regards

psurrey added a commit that referenced this issue Aug 4, 2017
@psurrey
Copy link
Contributor

psurrey commented Aug 4, 2017

Hi,

The node version for the cli itself is now specified in its package.json. Furthermore the generated project will have the version of node it was created with in its package.json.

Thank you for helping us improve the tool!

@psurrey psurrey closed this as completed Aug 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants