TNDO-4488 Allow special characters in report fields #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
THis way the standard format of package.json is kept as it is, but the user is able to upload it via the API. Since we are not showing the author's name anywhere we don't care how it is displayed at the end.
enkeleda-leanix
approved these changes
Jul 5, 2023
tog-leanix
deleted the
feature/TNDO-4488-allow-special-characters-in-report-fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to upload reports with the classic package.json syntax of the author. By replacing the brackets of the author field the API does not respond with an error but allows the upload. Since the author won't be visible in the UI this does not change anything for the upload of reports.