INVT-11343 Do not pin dependencies #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids that projects using this as a dependency get "stuck" on old version of transitive dependencies.
gul-leanix
force-pushed
the
feature/INVT-11343-fix-dependencies
branch
from
51df8c0
to
12b282f
Compare
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "$schema": "https://docs.renovatebot.com/renovate-schema.json", | |||
| "extends": ["config:js-app", "group:allNonMajor"], | |||
| "extends": ["config:js-lib", "group:allNonMajor"], | |||
There was a problem hiding this comment.
So we should do this for the other repos as well?
There was a problem hiding this comment.
Only for repos that are used as a dependency in other package.json files. Like this one, report-monitoring and reporting-dimensions (so that they don't force the consuming project to use specific versions of transitive dependencies).
For services and reports, "js-app" (ie. pinning all dependencies) is still a good choice.
enkeleda-leanix
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.