feat: implement JSX ... notation
#54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
force-pushed
the
splat-notation
branch
from
1745e3a
to
46e928e
Compare
Vtec234
reviewed
Apr 27, 2024
Vtec234
approved these changes
Apr 27, 2024
ProofWidgets/Data/Html.lean
Outdated
| /-- Interpolates an expression into a JSX literal -/ | ||
| scoped syntax "{" term "}" : jsxChild | ||
| scoped syntax jsxElement : jsxChild | ||
|
|
||
| scoped syntax:max jsxElement : term | ||
|
|
||
| def transformTag (n m : Ident) (ns : Array Ident) (vs : Array (TSyntax `jsxAttrVal)) | ||
| /-- Sends `#[a, b, c]` to `` `(term| $a ++ $b ++ $c)``-/ | ||
| def joinArrays {m} [Monad m] [MonadRef m] [MonadQuotation m] (arr : Array Term) : m Term := do |
There was a problem hiding this comment.
Could we move the general functions such as joinArrays/foldInlsM/delabListLiteral/... to a ProofWidgets.Util module?
There was a problem hiding this comment.
I've moved the new ones in this PR.
Vtec234
reviewed
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
<tag {...atts}>{...children}</tag>work, and adds support in the delaborator.The delaborator prints
<tag foo={1} {...attrs}><child />{...children}</tag>in a suboptimal way, but it's better than it was before.