feat: add varous lemmas for (Fin.rev _) #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While appreciating that the Std PR queue is slow, it's helpful if PRs are labelled when they are ready for review. Contributors can write a comment containing just |
|
awaiting-review |
github-actions
bot
added
the
awaiting-review
joehendrix
approved these changes
Dec 12, 2023
semorrison
approved these changes
Dec 12, 2023
joehendrix
added
will-merge-soon
semorrison
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 21, 2023
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 21, 2023
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These came up in Zulip. Let me know if there's a better place to put these lemmas.
Also, I'd be happy to mark as
@[simp], but I wasn't sure if we wanted to commit to pushingrevs in or out as simp-normal form. Pushing them in (as these lemmas do) seems natural as it's what we do with negation, butk.revis-1 - k, not-k, so I'm not sure what to think.