-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Std.Data.List.SplitOnList
#531
Closed
chabulhwi
wants to merge
9
commits into
leanprover-community:main
from
chabulhwi:Data.List.SplitOnList
Closed
feat: add Std.Data.List.SplitOnList
#531
chabulhwi
wants to merge
9
commits into
leanprover-community:main
from
chabulhwi:Data.List.SplitOnList
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chabulhwi
force-pushed
the
Data.List.SplitOnList
branch
4 times, most recently
from
January 15, 2024 16:19
31785a8
to
b5d8205
Compare
semorrison
reviewed
Jan 16, 2024
semorrison
reviewed
Jan 16, 2024
semorrison
reviewed
Jan 16, 2024
semorrison
reviewed
Jan 16, 2024
awaiting-author |
github-actions
bot
added
the
awaiting-author
Waiting for PR author to address issues
label
Jan 16, 2024
awaiting-review |
github-actions
bot
added
awaiting-review
This PR is ready for review; the author thinks it is ready to be merged.
and removed
awaiting-author
Waiting for PR author to address issues
labels
Jan 16, 2024
semorrison
reviewed
Jan 16, 2024
semorrison
reviewed
Jan 16, 2024
semorrison
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, LGTM.
chabulhwi
force-pushed
the
Data.List.SplitOnList
branch
2 times, most recently
from
January 16, 2024 06:37
8261f59
to
00976c2
Compare
chabulhwi
force-pushed
the
Data.List.SplitOnList
branch
2 times, most recently
from
January 17, 2024 05:03
3a076c7
to
6f1f6d2
Compare
Move a theorem from `Mathlib.Data.List.Basic` to Std.
* `List.splitOnceP` returns `(l₁, l₂)` for the first split `l = l₁ ++ l₂` such that `P l₂` returns true. * `List.splitOnList` splits a list at every occurrence of a separator list. The separators are not in the result. Co-authored-by: Mario Carneiro <di.gama@gmail.com>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
chabulhwi
force-pushed
the
Data.List.SplitOnList
branch
from
February 12, 2024 06:55
6f1f6d2
to
04d2a2e
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mathlib.Data.List.Basic
to Std.List.isPrefixOf
andList.isSuffixOf
.Std.Data.List.SplitOnList
.List.splitOnList
is a specification forString.splitOn
. We need it to proveString.splitOn_of_valid
, which is on the to-do list inStd.Data.String.Lemmas
.Co-authored-by: Mario Carneiro di.gama@gmail.com
Co-authored-by: Scott Morrison scott.morrison@gmail.com
See #495 for more context.