Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Actions #27

Merged
merged 9 commits into from
Jun 9, 2020
Merged

Github Actions #27

merged 9 commits into from
Jun 9, 2020

Conversation

bryangingechen
Copy link
Collaborator

This workflow builds mathlib docs for each commit pushed to any branch and additionally deploys the built docs to the web for each commit to master. (This way we don't have to manually trigger a build on mathlib to update the docs.)

@gebner
Copy link
Member

gebner commented Jun 4, 2020

I think it is a good idea to have CI here as well. I'm not so sure I like the duplication of the deployment logic and responsibility. I'm pretty sure we'll forget to update one of them in the future.

@bryangingechen
Copy link
Collaborator Author

bryangingechen commented Jun 4, 2020

Good point. As far as reducing deployment logic, I can try to make one script (merging ci.sh here and deploy_docs.sh in mathlib) that we can run both here and in mathlib's workflow. Would it be better to host that here or in mathlib?

Edit: I haven't done any work on this yet, but I've decided it makes more sense to put a script that builds mathlib docs in the mathlib scripts. We can revisit this down the line as doc-gen evolves.

bors bot pushed a commit to leanprover-community/mathlib that referenced this pull request Jun 7, 2020
This moves some installation steps out of `deploy_docs.sh` script and makes it accept several path arguments so that it can be re-used in the CI for `doc-gen`. 

The associated `doc-gen` PR: leanprover-community/doc-gen#27 will be updated after this is merged.
@bryangingechen
Copy link
Collaborator Author

OK, this now uses the deploy_docs.sh script from mathlib.

@robertylewis robertylewis merged commit 885b7e5 into master Jun 9, 2020
@robertylewis robertylewis deleted the actions branch June 9, 2020 08:58
@gebner
Copy link
Member

gebner commented Jun 10, 2020

It looks like there was a problem with authentication (CI has failed on master):

git push -f origin HEAD:master
remote: Invalid username or password.
fatal: Authentication failed for 'https://github.com/leanprover-community/mathlib_docs.git/'

@bryangingechen
Copy link
Collaborator Author

@gebner Yeah, I noticed this yesterday: 885b7e5#commitcomment-39774481

Basically, I forgot to add the secret before this PR was merged.

cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
…unity#2978)

This moves some installation steps out of `deploy_docs.sh` script and makes it accept several path arguments so that it can be re-used in the CI for `doc-gen`. 

The associated `doc-gen` PR: leanprover-community/doc-gen#27 will be updated after this is merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants