-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github Actions #27
Github Actions #27
Conversation
I think it is a good idea to have CI here as well. I'm not so sure I like the duplication of the deployment logic and responsibility. I'm pretty sure we'll forget to update one of them in the future. |
Good point. As far as reducing deployment logic, I can try to make one script (merging Edit: I haven't done any work on this yet, but I've decided it makes more sense to put a script that builds mathlib docs in the mathlib scripts. We can revisit this down the line as doc-gen evolves. |
This moves some installation steps out of `deploy_docs.sh` script and makes it accept several path arguments so that it can be re-used in the CI for `doc-gen`. The associated `doc-gen` PR: leanprover-community/doc-gen#27 will be updated after this is merged.
OK, this now uses the |
It looks like there was a problem with authentication (CI has failed on master):
|
@gebner Yeah, I noticed this yesterday: 885b7e5#commitcomment-39774481 Basically, I forgot to add the secret before this PR was merged. |
…unity#2978) This moves some installation steps out of `deploy_docs.sh` script and makes it accept several path arguments so that it can be re-used in the CI for `doc-gen`. The associated `doc-gen` PR: leanprover-community/doc-gen#27 will be updated after this is merged.
This workflow builds mathlib docs for each commit pushed to any branch and additionally deploys the built docs to the web for each commit to master. (This way we don't have to manually trigger a build on mathlib to update the docs.)