Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - ci(deploy_docs.sh): generalize for use in doc-gen CI #2978

Closed
wants to merge 2 commits into from

Conversation

bryangingechen
Copy link
Collaborator

This moves some installation steps out of deploy_docs.sh script and makes it accept several path arguments so that it can be re-used in the CI for doc-gen.

The associated doc-gen PR: leanprover-community/doc-gen#27 will be updated after this is merged.


@bryangingechen bryangingechen added CI This issue or PR is about continuous integration awaiting-review The author would like community review of the PR labels Jun 7, 2020
@robertylewis
Copy link
Member

I don't see any issues here at a glance. I guess it's a "test-in-production" kind of thing, right?

@bryangingechen
Copy link
Collaborator Author

Yeah, unfortunately. Same thing for the doc-gen PR, too.

@robertylewis
Copy link
Member

Well, the fact that this PR didn't push anything is a good sign!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 7, 2020
bors bot pushed a commit that referenced this pull request Jun 7, 2020
This moves some installation steps out of `deploy_docs.sh` script and makes it accept several path arguments so that it can be re-used in the CI for `doc-gen`. 

The associated `doc-gen` PR: leanprover-community/doc-gen#27 will be updated after this is merged.
@bors
Copy link

bors bot commented Jun 7, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title ci(deploy_docs.sh): generalize for use in doc-gen CI [Merged by Bors] - ci(deploy_docs.sh): generalize for use in doc-gen CI Jun 7, 2020
@bors bors bot closed this Jun 7, 2020
@bors bors bot deleted the doc-gen-ci branch June 7, 2020 18:12
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
…unity#2978)

This moves some installation steps out of `deploy_docs.sh` script and makes it accept several path arguments so that it can be re-used in the CI for `doc-gen`. 

The associated `doc-gen` PR: leanprover-community/doc-gen#27 will be updated after this is merged.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI This issue or PR is about continuous integration ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants