Added a header to mathlib index #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
Oct 25, 2021
gebner
reviewed
Oct 25, 2021
templates/index.j2
Outdated
| <ul> | ||
| <li>mathlib <a href="{{ mathlib_github_root }}/tree/{{ mathlib_commit }}">{{ mathlib_commit }}</a></li> | ||
| <li>Lean <a href="https://github.com/leanprover-community/lean/blob/{{ lean_commit }}/library">{{ lean_commit }}</a></li> | ||
| </ul> | ||
|
|
||
| <p>Note: mathlib is still only partially documented, and this HTML display is still |
There was a problem hiding this comment.
If you're already cleaning up the front page, then I would also remove this part.
Suggested change
| <p>Note: mathlib is still only partially documented, and this HTML display is still | |
| <p> |
templates/index.j2
Outdated
|
|
||
| {% block content %} | ||
| <h1>Welcome to mathlib's documentation page</h1> | ||
|
|
||
| <p>Navigate through mathlib files using the menu on the left.</p> |
There was a problem hiding this comment.
I think Partick already mentioned this on zulip, but it would be good to clarify at this point that this is the automatically-generated documentation from the docstrings in mathlib, and include a link to the main site.
|
#deploy |
|
This PR has been successfully deployed at http://leanprover-community.github.io/mathlib_docs_demo! |
|
#deploy |
|
This PR has been successfully deployed at http://leanprover-community.github.io/mathlib_docs_demo! |
gebner
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also mentioned commit hashes in list items for easier readability
Closes #138