Style: make <, ≤, >, ≥ looks better by removing links

[RaitoBezarius]

Those are only enabled upon hovering on them.

[bryangingechen]

Here's a screenshot of what things look like after your change:

One thing I don't like is that in hx : is_integral α x, I can't tell that is_integral is a link and that hx, α and x are not. Could you tweak the colors or some other feature to make the links stand out somehow?

[RaitoBezarius]

Guessed that it could create some issues, here's another patch which makes things a bit different, it still gives us links in hypothesis AFAIK. As order stuff has rarely hypothesis but most stuff seems to be in implications, etc. Let me know how it goes. :)

…

-- Ryan

On May 16 2020, at 3:52 am, Bryan Gin-ge Chen ***@***.***> wrote: Here's a screenshot of what things look like after your change: One thing I don't like is that in hx : is_integral α x, I can't tell that is_integral is a ilnk and that hx, α and x are not. Could you tweak the colors or some other feature to make the links stand out somehow? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. [ { ***@***.***": "http://schema.org", ***@***.***": "EmailMessage", "potentialAction": { ***@***.***": "ViewAction", "target": "#20 (comment)", "url": "#20 (comment)", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { ***@***.***": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

[RaitoBezarius]

Here's some dark theme screenshot (sorry for the dark theme! :D)

[bryangingechen]

Hmm, I actually kind of liked it more with all underlines removed by default, since they overlap with the underscores. Could you somehow make it so the non-links are more grayed out or less bold or something?

In your dark theme, I like the fact that for the second declaration theorem minimal_polynomial.monic, hx, α and x are actually a slightly different color which distinguishes them from the links. Not sure why that doesn't happen for def minimal_polynomial though.

Sorry for being picky!

[RaitoBezarius]

Hmm, I actually kind of liked it more with all underlines removed by default, since they overlap with the underscores. Could you somehow make it so the non-links are more grayed out or less bold or something?

We can definitely do something like this, I'll do it tomorrow, if that's okay.

In your dark theme, I like the fact that for the second declaration theorem minimal_polynomial.monic, hx, α and x are actually a slightly different color which distinguishes them from the links. Not sure why that doesn't happen for def minimal_polynomial though.

That's actually a side effect of a CSS filter from my GPU… :'D (I use the Dark Reader extension with Filter+).

Sorry for being picky!

Don't worry, it's all about the user experience.

[rwbarton]

In my opinion, even just deleting color: black and adding text-decoration: none looks fine, and definitely an improvement on the status quo:

I don't think the underlines are really needed on hover either, since the text color already changes on hover (at least in my browser).

[rwbarton]

Now I realize that links in the decl_args part (between the theorem name and the colon) aren't visible with my change, because their color gets overridden. So I would suggest taking the original commit, but also changing color: black; to color: #0000ee (this seems to be the usual default link color: https://stackoverflow.com/questions/4774022/whats-default-html-css-link-color)

[gebner]

Please make follow-up PRs if you like something else. But if we don't merge something now, then this will never be fixed.