New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup Test and CI #9
Conversation
Thank you very much for trying to contribute to The grand plan is to merge I have way too many projects going on in parallel, and Also note that pytest has no trouble adapting to any file layout, but this is besides the point. |
Thank you for your time!
Sorry, will do. Basically I was trying to make it "work" locally and the whole CI/PR thing is a side effect. Sending the PR simply because my local modification has reached a point that I need to check the compatibility with the original plan on
Great! Then my efforts will be redirected to that. P.S.
I do have some motivations for it as a side project and some time too(but no promise on that because I have a heavy day job completely unrelated to math or lean). I'll get back on Zulip to discuss it further after I learn more about |
Closing as this PR is obsolete. |
This PR adds basic tests and CI for format_lean. This PR is submitted for the initial review and discussions.
Rationale: I need to make modifications and add features to this tool at least for myself, but before adding anything serious, it's better to set up some basic tests and CI.
Details:
.exe
instead of a file without extension. This would be properly handled by entry_points.bin
, so the test can't import them and run tests on them, by moving them back to the main source, they can be accessedsrc
directory layer so it follows the standard directory structure thatpytest
would expect, this might be controversial, but I don't know how to makepytest
recognize the extrasrc
and don't want to do extra configuration since "conversion over configuration" would save much troublemathlibtools
of my own (will submit PR soon) to fix Support looking for leanpkg.toml in cwd mathlib-tools#59 in order for the CI to passP.S. Sorry for the small commits (which is to keep every commit self-explanatory and easy to review), but it can be squashed when merging anyway.