Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebuild lean.min.js #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Jan 20, 2022

An upstream change meant that the previous build no longer works.
The build tool was changed upstream to make this work again in highlightjs/highlight.js@76efccf.

This probably means that the new build will stop working on previous versions, but I doubt we can do much about that.

An upstream change means the previous build no longer works.
@bryangingechen
Copy link
Collaborator

Do you know roughly which versions will stop working? It might be good to add a warning in the README regarding compatibility.

@eric-wieser
Copy link
Member Author

No, I'm afraid I have no idea at all.

@bryangingechen
Copy link
Collaborator

I'm assuming you built this following the directions in the README, which involve cloning highlightjs? In hindsight, those instructions weren't very stable, since highlightjs master could (and did) end up incompatible with highlightjs-lean.

I'm thinking I should probably do the following:

  1. release a v11-compatible highlightjs-lean v2
  2. pin a compatible version of highlightjs in the build instructions in the README / the GitHub actions workflow
  3. add a note in the README pointing users of earlier versions of highlightjs to highlightjs-lean v1

@eric-wieser
Copy link
Member Author

I'm assuming you built this following the directions in the README, which involve cloning highlightjs? I

This is just the version that CI built for us, which AFAIR does follow those instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants