[Merged by Bors] - feat(widget): component.with_effects #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gebner
reviewed
Jun 30, 2020
src/frontends/lean/widget.cpp
Outdated
| lean_assert(g_context); | ||
| return g_context; | ||
| } | ||
| void set_global_widget_context(widget_context * wc) { |
There was a problem hiding this comment.
Please turn this into a scope_global_widget class.
Ideally, I'd like to avoid additional global variables. Is it instead possible to turn this into an extra argument to handle_event?
Instead it's passed as an argument. I think there is some possible refactoring so that everything lives inside widget_context. I am imagining something similar to pp_fn used in pp.cpp. But for now this will do.
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jul 2, 2020
supercedes #361 with this PR, the user can attach a `with_effects` hook to a component and cause side-effects in vscode when an action is performed, currently supported are; - highlighting parts of the doc, - revealing a location (eg go to definition) - inserting text above the cursor position. - also a 'custom' effect for prototyping new effects It should be fairly straightforward to add new effects if they are needed. see also leanprover/vscode-lean#193
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supercedes #361
with this PR, the user can attach a
with_effectshook to a component and cause side-effects in vscode when an action is performed, currently supported are;It should be fairly straightforward to add new effects if they are needed.
see also leanprover/vscode-lean#193