feat(widget): widgets emit widget.effects #361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
save_widget now has the type `pos -> component tactic_state widget.effects`. This means that now the widget-writer can cause widget.effects to issue a stream of commands to vscode to run side effects. Things like highlighting a particular region of code or revealing a location in the editor. The next task is to add 'go to definition' for the default tactic widget.
gebner
reviewed
Jun 26, 2020
gebner
reviewed
Jun 26, 2020
| | reveal_position (file_name : string) (p : pos) | ||
| | highlight_position (file_name : string) (p : pos) | ||
| | clear_highlighting | ||
| | custom (key : string) (value : string) |
There was a problem hiding this comment.
What do you think the custom effect will be used for? You need to modify the vscode extension anyhow for a new effect type.
There was a problem hiding this comment.
Yeah it just means that you can test out new effects without having to have a custom build of lean was the idea.
It still fails due to to_pos_info() not working?
Defaults to the current file, handled by vscode.
EdAyers
commented
Jun 26, 2020
The problem was that `list<vm_obj> to_list(vm_obj const & x)` was not doing what I thought it was doing.
bors bot
pushed a commit
that referenced
this pull request
Jul 2, 2020
supercedes #361 with this PR, the user can attach a `with_effects` hook to a component and cause side-effects in vscode when an action is performed, currently supported are; - highlighting parts of the doc, - revealing a location (eg go to definition) - inserting text above the cursor position. - also a 'custom' effect for prototyping new effects It should be fairly straightforward to add new effects if they are needed. see also leanprover/vscode-lean#193
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
save_widget now has the type
pos -> component tactic_state widget.effects -> tactic unit.This means that now the widget-writer can cause widget.effects
to issue a stream of commands to vscode to run side effects. Things like
highlighting a particular region of code or revealing a location in the
editor.
The next task is to add 'go to definition' for the default tactic
widget.
It should be backwards compatible with older versions, both for vscode and lean.