[Merged by Bors] - fix(library/init/meta/tactic): fix inaccurate failure messages in focus and focus' #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not a big deal, the error messages are just backwards here - when `focus` fails the error says that `focus'` failed, and vice versa.
|
Let's see if this breaks any tests. |
tryBuild failed: |
focus not focus'
|
bors try |
|
🔒 Permission denied Existing reviewers: click here to make lacker a reviewer |
|
Bah. Well, this test is failing because the test is just checking the precise error string returned. I fixed the test expected output. Let me know if that is considered OK or if there is more danger here |
|
That's the exact fix I would've done, so I think you're good. Thanks! |
bors bot
pushed a commit
that referenced
this pull request
Oct 15, 2020
…us and focus' (#483) Not a big deal, the error messages are just backwards here - when `focus` fails the error says that `focus'` failed, and vice versa.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a big deal, the error messages are just backwards here - when
focusfails the error says thatfocus'failed, and vice versa.