Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(library/init/function): use dot notation, add some docstrings #216

Closed
wants to merge 4 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented May 7, 2020

Renamed (in function namespace):

  • injective_comp, surjective_comp, bijective_comp: injective.comp, surjective.comp, bijective.comp;
  • injective_of_left_inverse : left_inverse.injective;
  • injective_of_has_left_inverse: has_left_inverse.injective;
  • surjective_of_has_right_inverse: has_right_inverse.surjective;
  • `right_inverse.surjective (new);
  • id_of_left_inverse, id_of_right_inverse: left_inverse.id, right_inverse.id (both protected).

@urkud
Copy link
Member Author

urkud commented May 7, 2020

Test tests/lean/doc_strings.lean fails because it outputs docstrings of all loaded modules thus assumes that no files in prelude have module docs. What is the correct fix: filter the list before printing it? Something else?

@gebner
Copy link
Member

gebner commented May 7, 2020

What is the correct fix: filter the list before printing it? Something else?

I would remove the olean_doc_strings line. The module_doc_strings is already a function that filters olean_doc_strings.

@urkud
Copy link
Member Author

urkud commented May 7, 2020

BTW, should we move some of these lemmas to mathlib instead?

@gebner
Copy link
Member

gebner commented May 11, 2020

bors merge

bors bot pushed a commit that referenced this pull request May 11, 2020
…216)

Renamed (in `function` namespace):

* `injective_comp`, `surjective_comp`, `bijective_comp`: `injective.comp`, `surjective.comp`, `bijective.comp`;
* `injective_of_left_inverse` : `left_inverse.injective`;
* `injective_of_has_left_inverse`: `has_left_inverse.injective`;
* `surjective_of_has_right_inverse`: `has_right_inverse.surjective`;
* `right_inverse.surjective (new);
* `id_of_left_inverse`, `id_of_right_inverse`: `left_inverse.id`, `right_inverse.id` (both `protected`).
@bors
Copy link

bors bot commented May 11, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(library/init/function): use dot notation, add some docstrings [Merged by Bors] - chore(library/init/function): use dot notation, add some docstrings May 11, 2020
@bors bors bot closed this May 11, 2020
@urkud urkud deleted the dot-notation branch October 22, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants