Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix(expr): add functionality for let expressions #432

Closed
wants to merge 2 commits into from

Conversation

fpvandoorn
Copy link
Member

@fpvandoorn fpvandoorn commented Aug 6, 2020

add doc strings to some declarations
fix bug in in_current_file


Can I use library notes in core?
After merging, we can remove in_current_file' from mathlib.

add doc strings to some declarations
fix bug in in_current_file
@gebner
Copy link
Member

gebner commented Aug 7, 2020

For the future: you get twice the credit if you open two PRs! 😄

Can I use library notes in core?

I wouldn't write see note [foo] where foo is defined in mathlib, although maybe see note [foo] in mathlib could be acceptable. If you want to define library notes in core, then you'll need to port it to core but I'm not sure if it's worth the effort.

bors r+

bors bot pushed a commit that referenced this pull request Aug 7, 2020
add doc strings to some declarations
fix bug in `in_current_file`

---

Can I use library notes in core?
After merging, we can remove `in_current_file'` from mathlib.
@bors
Copy link

bors bot commented Aug 7, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix(expr): add functionality for let expressions [Merged by Bors] - fix(expr): add functionality for let expressions Aug 7, 2020
@bors bors bot closed this Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants