Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix(library/vm/vm_json): do not treat empty objects as null #534

Closed
wants to merge 3 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Feb 19, 2021

Previously json.unparse on an empty object would produce "null", which broke both the repr and serialization.

@bryangingechen bryangingechen changed the title bug(library/vm/vm_json): do not treat empty objects as null fix(library/vm/vm_json): do not treat empty objects as null Feb 19, 2021
@gebner
Copy link
Member

gebner commented Feb 19, 2021

bors r+

bors bot pushed a commit that referenced this pull request Feb 19, 2021
Previously `json.unparse` on an empty object would produce `"null"`, which broke both the repr and serialization.
@bors
Copy link

bors bot commented Feb 19, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix(library/vm/vm_json): do not treat empty objects as null [Merged by Bors] - fix(library/vm/vm_json): do not treat empty objects as null Feb 19, 2021
@bors bors bot closed this Feb 19, 2021
@bors bors bot deleted the eric-wieser/json-fix branch February 19, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants