Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(library/init/coe): backport has_coe_to_sort/has_coe_to_fun from Lean 4 #557

Closed
wants to merge 19 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Mar 18, 2021

No description provided.

@urkud urkud added the WIP Work in progress label Mar 18, 2021
@gebner
Copy link
Member

gebner commented Mar 18, 2021

bors try

bors bot added a commit that referenced this pull request Mar 18, 2021
@bors
Copy link

bors bot commented Mar 18, 2021

try

Build failed:

@eric-wieser
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Mar 19, 2021
@bors
Copy link

bors bot commented Mar 19, 2021

try

Build failed:

@urkud
Copy link
Member Author

urkud commented Mar 21, 2021

bors try

bors bot added a commit that referenced this pull request Mar 21, 2021
@bors
Copy link

bors bot commented Mar 21, 2021

@urkud urkud added awaiting-review and removed WIP Work in progress labels Mar 24, 2021
@urkud
Copy link
Member Author

urkud commented Mar 25, 2021

The following example fails with the new has_coe_to_sort:

universe u

instance {α : Type u} : has_coe_to_sort (set α) (Type u) := ⟨λ s, {x // x ∈ s}⟩

example : ↥({0} : set ℕ) := ⟨0, rfl⟩

Error: "5:29: invalid constructor ⟨...⟩, 'has_coe_to_sort.coe' is not an inductive type"

I have no idea why this happens.

@bryangingechen
Copy link
Collaborator

bors try

bors bot added a commit that referenced this pull request Mar 26, 2021
@bors
Copy link

bors bot commented Mar 26, 2021

@eric-wieser
Copy link
Member

What's the status of this PR?

@gebner
Copy link
Member

gebner commented Oct 19, 2021

bors r+

bors bot pushed a commit that referenced this pull request Oct 19, 2021
…rom Lean 4 (#557)

Co-authored-by: Gabriel Ebner <gebner@gebner.org>
@bors
Copy link

bors bot commented Oct 19, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(library/init/coe): backport has_coe_to_sort/has_coe_to_fun from Lean 4 [Merged by Bors] - feat(library/init/coe): backport has_coe_to_sort/has_coe_to_fun from Lean 4 Oct 19, 2021
@bors bors bot closed this Oct 19, 2021
@urkud urkud deleted the coe-fn-backport branch October 22, 2021 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants